Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.4.1 backports 1 #36018

Merged
merged 30 commits into from
Sep 20, 2023
Merged

3.4.1 backports 1 #36018

merged 30 commits into from
Sep 20, 2023

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Sep 19, 2023

Please don't merge, I will merge it myself.

cescoffier and others added 30 commits September 15, 2023 09:50
- Use normalized path to check Keycloak authorization policies
- Use normalised path for Servlet
- Use normalized path to check CSRF token path constraint

Co-authored-by: Michal Vavrik <[email protected]>
Co-authored-by: Stuart Douglas <[email protected]>
Co-authored-by: Sergey Beryozkin <[email protected]>
Co-authored-by: Clement Escoffier <[email protected]>
The problem is causes by 2aef532
which contained a Maven exclusion
which results in the dependency not being
added when the client and server part
are mixed.

Fixes: quarkusio#35889
(cherry picked from commit 596d388)
These were erroneously removed in 19aae16

(cherry picked from commit cafcc52)
Signed-off-by: Michal Maléř <[email protected]>
(cherry picked from commit 43f5225)
(cherry picked from commit dc226c9)
Bumps org.apache.commons:commons-compress from 1.23.0 to 1.24.0.

---
updated-dependencies:
- dependency-name: org.apache.commons:commons-compress
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
(cherry picked from commit bb6ecde)
Bumps org.apache.commons:commons-compress from 1.23.0 to 1.24.0.

---
updated-dependencies:
- dependency-name: org.apache.commons:commons-compress
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
(cherry picked from commit e65f535)
If the Redis client cannot connect to Redis (and only in this case), recompute the value.
The value is neither cached nor written in the cache, making the cache implementation more robust to transient network issues.
A log message (warning) has been added to detect the issue.

Co-authored-by: Monhemius, B. (Bart) <[email protected]>
Co-authored-by: Clement Escoffier <[email protected]>
(cherry picked from commit c2b4860)
We introduce an injection point to the
synthetic bean creation process thus
giving Arc all the declarative context
it needs in order to ensure proper bean
creation order

(cherry picked from commit dc78468)
RESTEasy Classic does not ignore them,
so let's keep the same behavior

Closes: quarkusio#35966
(cherry picked from commit a3ba466)
(cherry picked from commit 7fb2bc9)
Bumps org.eclipse.jgit:org.eclipse.jgit from 6.6.0.202305301015-r to 6.6.1.202309021850-r.

---
updated-dependencies:
- dependency-name: org.eclipse.jgit:org.eclipse.jgit
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
(cherry picked from commit 8580a46)
Bumps org.eclipse.jgit:org.eclipse.jgit from 6.6.0.202305301015-r to 6.6.1.202309021850-r.

---
updated-dependencies:
- dependency-name: org.eclipse.jgit:org.eclipse.jgit
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
(cherry picked from commit 17195f6)
(cherry picked from commit f6027e8)
I wasn't exactly aware of this new development and it needs to be
handled a bit differently.

(cherry picked from commit 797162a)
@gsmet gsmet added the area/infra internal and infrastructure related issues label Sep 19, 2023
@gsmet gsmet self-assigned this Sep 19, 2023
@quarkus-bot quarkus-bot bot added area/config area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/flyway area/hibernate-search Hibernate Search area/keycloak area/oidc area/persistence OBSOLETE, DO NOT USE area/platform Issues related to definition and interaction with Quarkus Platform area/reactive-sql-clients area/resteasy-classic area/rest area/security area/tracing area/undertow area/vertx labels Sep 19, 2023
@github-actions
Copy link

github-actions bot commented Sep 19, 2023

🙈 The PR is closed and the preview is expired.

@quarkus-bot
Copy link

quarkus-bot bot commented Sep 20, 2023

Failing Jobs - Building 3601abd

Status Name Step Failures Logs Raw logs Build scan
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
JVM Tests - JDK 17 Windows Build Failures Logs Raw logs
JVM Tests - JDK 20 Build ⚠️ Check → Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 Windows #

- Failing: extensions/vertx/deployment 
! Skipped: devtools/cli extensions/agroal/deployment extensions/amazon-lambda-http/deployment and 377 more

📦 extensions/vertx/deployment

io.quarkus.vertx.mdc.VertxMDCTest.mdc line 144 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <10> but was: <0>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

io.quarkus.vertx.mdc.VertxMDCTest.mdcNonVertxThreadTest line 121 - More details - Source on GitHub

java.lang.AssertionError: 

Expected: a collection containing "Test MDC value ### Test 1"

@gsmet gsmet merged commit f9b4721 into quarkusio:3.4 Sep 20, 2023
52 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/config area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/flyway area/hibernate-search Hibernate Search area/infra internal and infrastructure related issues area/keycloak area/oidc area/persistence OBSOLETE, DO NOT USE area/platform Issues related to definition and interaction with Quarkus Platform area/reactive-sql-clients area/rest area/resteasy-classic area/security area/tracing area/undertow area/vertx
Projects
None yet
Development

Successfully merging this pull request may close these issues.